Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): cdk version displays notices #19181

Merged
merged 1 commit into from
Feb 28, 2022
Merged

fix(cli): cdk version displays notices #19181

merged 1 commit into from
Feb 28, 2022

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Feb 28, 2022

One of our integration tests started failing after a notice was added because cdk version displayed information besides the actual CLI version:

 ● Two ways of shoing the version

    expect(received).toEqual(expected) // deep equality

    - Expected  -  0
    + Received  + 14

      2.14.0 (build 762d71b)
    +
    + NOTICES
    +
    + 19179 (aws-eks): Regression in installing Helm charts from assets
    +
    +   Overview: Helm charts fail to install when provided as an asset. This
    +             issue does not affect charts installed from a repository.
    +
    +   Affected versions: framework: 2.14.0, framework: 1.146.0
    +
    +   More information at: https://github.com/aws/aws-cdk/issues/19179
    +
    +
    + If you don’t want to see a notice anymore, use "cdk acknowledge <id>". For example, "cdk acknowledge 19179".

      at cli.integtest.ts:39:20
      at ../helpers/cdk.ts:130:7
      at ResourcePool.using (../helpers/resource-pool.ts:44:14)
      at ../helpers/test-helpers.ts:30:14

This fixes that bug.

Another option we could consider here is to keep the current behavior (where cdk version and cdk --version display different output) and just update the test case, but I think keeping them the same is probably simpler for customers.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@Chriscbr Chriscbr requested a review from a team February 28, 2022 01:32
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 28, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: faaabd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fa16f7a into master Feb 28, 2022
@mergify mergify bot deleted the rybickic/fix-version branch February 28, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants