Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update enum types to remove duplicate member values #19320

Merged
merged 7 commits into from
Jun 30, 2022

Commits on Mar 10, 2022

  1. refactor: update enum types to remove duplicate member values

    CDK has some enums which use the same value for different enum members. This is done to support friendly names for EC2 instance and Subnet type. Having same value for differnt members causes the typescript compiler to ignore the members with same value and causes JSII not to generate the enum members in other languages. To fix this [JSII will throw an error](aws/jsii#3412) when enum members have the same value. Updating CDK code to ensure the build pass when this change lands in JSII
    
    re #aws/jsii#3412
    yuth committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    50f0b32 View commit details
    Browse the repository at this point in the history
  2. chore: remove unneeded files

    yuth committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    867b9c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e9ca1d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f66e7fa View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Configuration menu
    Copy the full SHA
    7270e3f View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Missing instance types

    rix0rrr committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    e68c6ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fdefb39 View commit details
    Browse the repository at this point in the history