-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): warn if you use function.grantInvoke
while also using currentVersion
#19464
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cafdc6b
chnages to add permission
kaizencc d6c183f
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc e6b4610
test latest version
kaizencc 50bbab1
test latest version
kaizencc ef23549
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc 7204adc
use template pattern for overriding base class functions
kaizencc be42368
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc 1b7f94b
only add warning when currentVersion invoked
kaizencc 3c250f3
update documentation
kaizencc 3b03c84
remove duplicate test
kaizencc bae6a87
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc 465279d
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc f974469
Merge branch 'master' into conroy/update-lambda-resource-policies
kaizencc 0fc25bd
Merge branch 'master' into conroy/update-lambda-resource-policies
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LatestVersion
is a special case that cannot have permissions added to it, since it is a dynamic qualifier. The typical use case is to alias the latest version, and then apply permissions to the alias. All other qualified functions use theQualifiedFunctionBase
class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually something people do? What's the value over just adding permissions to the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually something people do? IDK, but I'm reading from the
LatestVersion
docstring that says:At any rate you cannot add permissions to $LATEST.