Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(events-targets): migrate a test to use assertions' annotations class #19465

Merged
merged 3 commits into from
Mar 21, 2022
Merged

chore(events-targets): migrate a test to use assertions' annotations class #19465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b796224
fix test
kaizencc Mar 18, 2022
c1bf7db
Update aws-api.test.ts
kaizencc Mar 21, 2022
1f0c78f
Merge branch 'master' into conroy/eventfix
mergify[bot] Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/@aws-cdk/aws-events-targets/test/aws-api/aws-api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Template } from '@aws-cdk/assertions';
import { Annotations, Template } from '@aws-cdk/assertions';
import * as events from '@aws-cdk/aws-events';
import * as iam from '@aws-cdk/aws-iam';
import { App, Stack } from '@aws-cdk/core';
import { Stack } from '@aws-cdk/core';
import * as targets from '../../lib';

test('use AwsApi as an event rule target', () => {
Expand Down Expand Up @@ -163,9 +163,5 @@ test('with service not in AWS SDK', () => {
rule.addTarget(awsApi);

// THEN
const assembly = App.of(stack)!.synth().getStackArtifact(stack.stackName);
expect(assembly.messages.length).toBe(1);
const message = assembly.messages[0];
expect(message.entry.type).toBe('aws:cdk:warning');
expect(message.entry.data).toBe('Service no-such-service does not exist in the AWS SDK. Check the list of available services and actions from https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/index.html');
Annotations.fromStack(stack).hasWarning('*', 'Service no-such-service does not exist in the AWS SDK. Check the list of available services and actions from https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/index.html');
});