-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glue): add L2 resources for Database
and Table
#1988
Merged
Merged
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3551d75
Add glue database and table
3de3b03
Add unit tests for database and schema
e4df159
Stash
502b0cb
Improve test coverage of table
a08dc37
Add integration tests and README
f4db178
Update README with types
0d10989
Add validation for name uniqueness and at least one column
cf6d56d
Use strongly named references
9dc8e57
Update StorageType enums to be enum-like classes
c7f62d7
Add SSE-S3 and SSE-KMS encryption support
e0043a9
Restrict s3 grants to only objects containing the table's prefix
231c36a
Add tsdocs for Type
cee2e46
Add Encryption to README
4595fde
Add CSE encryption and distinguish SSE-KMS from SSE-KMS-MANAGED
b8f886b
Minor fixes to the README
db1960b
Some more minor fixes to the README
d245b1c
Merge branch 'master' into samgood/glue
f98d5fd
Rename prefix to s3Prefix and use haveResource in tests
d3ccd53
Use string concatentation
538cff9
Add docs and fix string concatenation
0c2f7fa
Rename StorageType to DataFormat
1cb7c4f
Improve docs and make the TableEncryption enum more consistent with B…
a5d45f0
Refactor s3 bucket creation into separate function and support unencr…
30f8a3c
add test for CSE-KMS with an explicit bucket
45434fe
minor fixes to README
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum names should be consistent with
BucketEncryption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue the other way around - the enum values are consistent with the S3, Athena, Glue and EMR documentation. What would I name
CSE-KMS
if I were copyingBucketEncryption
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, but I think we have a problem with ALL_CAPS when converting those member names to other languages. Can we find names that are PascalCase?