-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependabot and yarn-upgrade config #19942
Conversation
with: | ||
ref: v1-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 1 of 2 changes between this file and yarn-upgrade.yml
.
with: | ||
ref: v1-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the other. peter-evans/create-pull-request
creates a pull request to the branch checked out in the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaizen3031593, it looks like this PR accidentally has a bunch of unrelated changes in it? Integration tests, README, CfnSpec files, etc. Can you remove them?
@madeline-k I think the unrelated changes has to do with v1 not being in sync with v2. The forward merge got through to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please do not remove the "do-not-merge" label
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closes https://github.com/cdklabs/cdk-ops/issues/1942
The idea is to copy the configuration we already have for the default branch and target/checkout
v1-main
on June 1.It is a bit ugly but -- we are not likely to do this again to any other branch, and I can't think of a better way. I have tested the changes on my own forked repository and confirmed that we do indeed target/checkout a different branch under the new configuration.
Before this PR is merged, we should double-check and make sure that yarn-update has not diverged. Targeting
v2-main
as that will be the default branch when this PR gets merged (I assume the conflicts will be resolved whenv2-main
gets forward merged).All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license