Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-ecs): update python version on InstanceDrainHook handler #19943

Closed
wants to merge 6 commits into from

Conversation

Imamachi-n
Copy link

@Imamachi-n Imamachi-n commented Apr 16, 2022

General Issue

Documentation

  • A hook to drain instances from ECS traffic is implemented in Python 3.6.
  • The code is under lib/drain-hook and unit tests are under test/ec2.

Resolution

  • Need to update the Lambda Python version having more than 3.6 (Python 3.7)

Environment

  • CDK Version: 2.20.0 / 1.152.0

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 16, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 16, 2022 04:17
@github-actions github-actions bot added the p2 label Apr 16, 2022
@Imamachi-n Imamachi-n changed the title chore(aws-ecs): update python version on InstanceDrainHook handler chore(ecs): update python version on InstanceDrainHook handler Apr 16, 2022
@Imamachi-n Imamachi-n changed the title chore(ecs): update python version on InstanceDrainHook handler chore(aws-ecs): update python version on InstanceDrainHook handler Apr 16, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2269fff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc
Copy link
Contributor

kaizencc commented May 4, 2022

Thanks for opening this PR! We're going to catch all of these in #19988 I believe. Sorry, I know yours came first but we want to update them all at the same time and to the latest runtime.

@kaizencc kaizencc closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants