-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): grant function permissions to an AWS organization #19975
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fca493b
update readme to reflect new feature
kaizencc 34f5cae
add new prop and change docs for principal
kaizencc d2122d2
more doc changes
kaizencc 71e6bd6
main commit with changes to permission handling and testing
kaizencc 3b4311f
add integ test
kaizencc 545dc73
fix snippets
kaizencc 1d89444
Merge branch 'master' into conroy/lambda-perms
kaizencc fb5a9d2
Merge branch 'master' into conroy/lambda-perms
kaizencc d4c2904
update readme to reflect potential convenience method in iam
kaizencc 60022d7
remove instanceOf in favor of parsing the conditions
kaizencc b6769bb
some changes from pr feedback
kaizencc da48f1d
Merge branch 'master' into conroy/lambda-perms
kaizencc 4ad0b40
Merge branch 'conroy/lambda-perms' of https://github.com/aws/aws-cdk …
kaizencc c26d3ad
update integ test and fix bug in isPrincipalWithConditions
kaizencc b5f1e1b
Merge branch 'master' into conroy/lambda-perms
kaizencc 2f64196
fix(lambda): grant function permissions does not accept sourceArn con…
kaizencc 8afe9e7
pr feedback
kaizencc 0e2202f
Merge branch 'main' into conroy/lambda-perms
kaizencc d453215
Merge branch 'main' into conroy/lambda-perms
kaizencc 48488eb
update permissions integ snapshot
kaizencc 9b8f92e
Merge branch 'main' into conroy/lambda-perms
kaizencc c432d65
refactor org principal logic
kaizencc 99d9d5a
Merge branch 'main' into conroy/lambda-perms
mergify[bot] bbc7420
Merge branch 'main' into conroy/lambda-perms
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug to me.
OrganizationPrincipal
does not have aconditions
property but its policy fragment does have a condition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. But watch out! The return type of this function is a type assertion, which is now no longer true! You need to fix the return type and callsites as well.