chore(cfnspec): Add coverage directory to npmignore #20016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rix0rrr
approved these changes
Jun 30, 2022
|
@Mergifyio backport main |
🟠 Waiting for conditions to match
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
Installing cfnspec shows the coverage directory is being published to npm. I assume this should be excluded since build artifacts aren't typically published, and at a glance most CDK packages exclude any build artifacts from the published package. (If there is a specific reason why the coverage folder is being published, please advise since I'd be interested to understand the use case.) ``` $ npm install @aws-cdk/cfnspec $ ls -1 node_modules/@aws-cdk/cfnspec/ CHANGELOG.md LICENSE coverage lib package.json ... $ ls -1 node_modules/@aws-cdk/cfnspec/coverage base.css block-navigation.js build-tools favicon.png index.html junit.xml ... ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * N/A ### New Features * N/A *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit f15b18a)
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jun 30, 2022
…#20931) This is an automatic backport of pull request #20016 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…) (aws#20931) This is an automatic backport of pull request aws#20016 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing cfnspec shows the coverage directory is being published to npm. I assume this should be excluded since build artifacts aren't typically published, and at a glance most CDK packages exclude any build artifacts from the published package. (If there is a specific reason why the coverage folder is being published, please advise since I'd be interested to understand the use case.)
All Submissions:
Adding new Unconventional Dependencies:
New Features
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license