Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-python): Pipenv projects no longer work for Python 3.6 #20019

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix(lambda-python): Pipenv projects no longer work for Python 3.6 #20019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@aws-cdk/aws-lambda-python/lib/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ ARG HTTPS_PROXY

# Upgrade pip (required by cryptography v3.4 and above, which is a dependency of poetry)
RUN pip install --upgrade pip
RUN pip install pipenv poetry

# pipenv 2022.4.8 is the last version with Python 3.6 support
RUN pip install pipenv==2022.4.8 poetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should handle this the same way we handle awscli with lambda-layer-awscli

aws-cdk/packages/@aws-cdk/lambda-layer-awscli/layer/Dockerfile

Lines 18 to 19 in 10f5ede

COPY requirements.txt ./
RUN python -m pip install -r requirements.txt -t /opt/awscli


CMD [ "python" ]