Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): add secret rotation to
DatabaseClusterFromSnapshot
#20020feat(rds): add secret rotation to
DatabaseClusterFromSnapshot
#20020Changes from all commits
832cd10
149a234
6343c00
087be25
8f5e4fc
48a121f
12f43eb
935a85a
cb98dd4
ca54a07
14eb140
0d06cdd
404aa1b
b71b43b
89ebe6c
0a39384
2c20551
f50ed87
be05028
324166b
a9fb890
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do an error case for a missing secret on multi user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like right now a secret is required in
RotationMultiUserOptions
, unlike inRotationSingleUserOptions
, so a similar test as inaddRotationSingleUser
cannot be constructed foraddRotationMultiUser
. Can you advise a bit further? Thank you!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I was wrong here. Your error cases are fine.