You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the language in CONTRIBUTING.md and in each CFN-only module's README to require all L2 implementation PRs to first have an approved RFC. This will avoid contributors having to redesign APIs after they've already implemented them in a pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this pull request
May 23, 2022
Updates the language in `CONTRIBUTING.md` and in each CFN-only module's README to require all L2 implementation PRs to first have an approved RFC. This will avoid contributors having to redesign APIs after they've already implemented them in a pull request.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comcalvi
added
the
pr-linter/exempt-readme
Updates the language in
CONTRIBUTING.mdand in each CFN-only module's README to require all L2 implementation PRs to first have an approved RFC. This will avoid contributors having to redesign APIs after they've already implemented them in a pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license