Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs_patterns): Enable enableExecutecommand as default #20047

Closed
wants to merge 1 commit into from
Closed

feat(ecs_patterns): Enable enableExecutecommand as default #20047

wants to merge 1 commit into from

Conversation

deuscapturus
Copy link

Expose enableExecutecommand as a property in ecs_patterns constructs for Fargate and Ec2.

Default enableExecutecommand = true.

Enabling execute command is a sensible default for the high level ecs_patterns construct.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 22, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 22, 2022 20:23
@github-actions github-actions bot added the p2 label Apr 22, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6acab90
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@hoegertn
Copy link
Contributor

My 2ct: While I love being able to activate this feature, I do not think it should be active by default.

Being able to execute into a container is not a safe default from a security and/or compliance point of view.

@LukvonStrom
Copy link
Contributor

Integrating without setting as default is done at #18663 @hoegertn

@deuscapturus
Copy link
Author

I'll close if #18663 is merged.

@github-actions
Copy link

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions
Copy link

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 22, 2022
@github-actions github-actions bot closed this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants