Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python Support #2009

Merged
merged 4 commits into from
Mar 28, 2019
Merged

feat: Python Support #2009

merged 4 commits into from
Mar 28, 2019

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Mar 13, 2019

Fixes #539


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@dstufft dstufft requested review from RomainMuller, skinny85, SoManyHs and a team as code owners March 13, 2019 14:41
@dstufft dstufft changed the title [WIP] Configure the CDK to target Python [WIP] Python Support Mar 13, 2019
@dstufft dstufft force-pushed the python-redux branch 2 times, most recently from a7424bf to 9e51344 Compare March 13, 2019 14:45
@dstufft
Copy link
Contributor Author

dstufft commented Mar 13, 2019

Built everything and installed it into a virtual environment, then ensured everything was importable by running:

import pkgutil
import importlib

import aws_cdk


for pkg in pkgutil.walk_packages(aws_cdk.__path__, "aws_cdk."):
    print(f"Importing {pkg.name}")
    importlib.import_module(pkg.name)

That does not ensure it's functioning, but it is at least importable.

@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 18, 2019

Don't forget to update create-missing-libraries.ts, it will be invoked to bootstrap a new package.

@dstufft dstufft force-pushed the python-redux branch 3 times, most recently from 7fc09fc to f53c289 Compare March 26, 2019 21:20
@Doug-AWS Doug-AWS mentioned this pull request Mar 28, 2019
@dstufft dstufft requested a review from eladb March 28, 2019 13:15
@dstufft dstufft changed the title [WIP] Python Support Python Support Mar 28, 2019
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me 👍🏻

@eladb
Copy link
Contributor

eladb commented Mar 28, 2019

Approved conditional of name changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python language support
4 participants