Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk-assets): osx cannot publish docker images in parallel #20107

Closed
wants to merge 1 commit into from

Conversation

misterjoshua
Copy link
Contributor

@misterjoshua misterjoshua commented Apr 27, 2022

This PR disables parallel asset publishing for OSX when docker image assets are present.

Potential short-term fix for: #19367 (comment)


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 27, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 27, 2022 21:15
@github-actions github-actions bot added the p2 label Apr 27, 2022
@misterjoshua misterjoshua changed the title fix: osx cannot publish docker images in parallel fix(cdk-assets): osx cannot publish docker images in parallel Apr 27, 2022
@misterjoshua
Copy link
Contributor Author

misterjoshua commented Apr 27, 2022

I'm leaving this here as an option, but currently trying to figure out how to docker login only once per destination.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 062e325
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@misterjoshua misterjoshua marked this pull request as ready for review April 27, 2022 22:18
@misterjoshua
Copy link
Contributor Author

I found a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants