Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cognito): UserPoolDomain.baseUrl() does not return FIPS-compliant url for gov cloud regions #20200

Merged
merged 4 commits into from
May 5, 2022

Conversation

laurelmay
Copy link
Contributor

@laurelmay laurelmay commented May 3, 2022

This ensures that users in GovCloud can retrieve a URL that works in
their region and allows users in us-{east,west}-{1,2} to also use the
FIPs endpoints.

Partially discussed in #20182.

Resolves #12500


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 3, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 3, 2022 19:22
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels May 3, 2022
@laurelmay laurelmay force-pushed the cognito-full-domain branch from 655bd60 to 439a0b9 Compare May 3, 2022 19:22
This ensures that users in GovCloud can retrieve a URL that works in
their region and allows users in us-{east,west}-{1,2} to also use the
FIPs endpoints. This also modifies `signInUrl` to add the same
functionality (and pass it through to `baseUrl`).
@laurelmay laurelmay force-pushed the cognito-full-domain branch from 439a0b9 to 52c70a2 Compare May 3, 2022 19:37
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(cognito): Allow retrieving FIPS-compliant URL fix(cognito): UserPoolDomain.baseUrl() does not return FIPS-compliant url for gov cloud May 4, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(cognito): UserPoolDomain.baseUrl() does not return FIPS-compliant url for gov cloud fix(cognito): UserPoolDomain.baseUrl() does not return FIPS-compliant url for gov cloud regions May 4, 2022
@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b4533c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dd10df1 into aws:master May 5, 2022
@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
… url for gov cloud regions (aws#20200)

This ensures that users in GovCloud can retrieve a URL that works in
their region and allows users in us-{east,west}-{1,2} to also use the
FIPs endpoints.

Partially discussed in aws#20182.

Resolves aws#12500

----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cognito): UserPoolDomain.baseUrl() returns incorrect URL for gov cloud
3 participants