Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): allow SSO profiles to be used as source profiles #20340

Merged
merged 6 commits into from
May 14, 2022

Conversation

comcalvi
Copy link
Contributor

SSO profiles can now be used as source profiles.

Fixes #19897.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested a review from rix0rrr May 13, 2022 20:22
@gitpod-io
Copy link

gitpod-io bot commented May 13, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 13, 2022 20:23
@github-actions github-actions bot added bug This issue is a bug. p1 labels May 13, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 13, 2022
@comcalvi comcalvi added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes labels May 13, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7f33ced
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 14, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a0b29e9 into aws:master May 14, 2022
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
SSO profiles can now be used as source profiles.

Fixes aws#19897.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk: assumed roles using source_profile from SSO sources cannot get credentials
3 participants