Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ-runner): --inspect-failures option #20399

Merged
merged 2 commits into from
May 20, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 18, 2022

When the integ runner fails to validate a snapshot, add an option
to retain the tempdir with the "new actual" snapshot so that a human
can go look around in it.

Also make the --verbose flag print out a command that will reproduce
the running of the CDK app directly from the command-line, so that
it can be debugged more easily.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

When the integ runner fails to validate a snapshot, add an option
to retain the tempdir with the "new actual" snapshot so that a human
can go look around in it.

Also make the `--verbose` flag print out a command that will reproduce
the running of the CDK app directly from the command-line, so that
it can be debugged more easily.
@rix0rrr rix0rrr requested a review from a team May 18, 2022 13:03
@rix0rrr rix0rrr self-assigned this May 18, 2022
@gitpod-io
Copy link

gitpod-io bot commented May 18, 2022

@github-actions github-actions bot added the p2 label May 18, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 18, 2022 13:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 18, 2022
@rix0rrr rix0rrr added the effort/small Small work item – less than a day of effort label May 18, 2022
@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4ff9074
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 484cfb2 into master May 20, 2022
@mergify mergify bot deleted the huijbers/integ-runner-inspect branch May 20, 2022 14:03
@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
When the integ runner fails to validate a snapshot, add an option
to retain the tempdir with the "new actual" snapshot so that a human
can go look around in it.

Also make the `--verbose` flag print out a command that will reproduce
the running of the CDK app directly from the command-line, so that
it can be debugged more easily.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants