Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): add support for caching to codebuild steps #20533

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Hi-Fi
Copy link
Contributor

@Hi-Fi Hi-Fi commented May 28, 2022

Fixes #16375

Closes #19084


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 28, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 28, 2022 18:08
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels May 28, 2022
@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented May 28, 2022

@rix0rrr Opened new PR with tests to supersede #19084 which seemed quite silent for a long time. Hopefully this is something that can be merged, as at least original PR didn't had any implementation related comments/concerns.

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 09:08
@Hi-Fi Hi-Fi force-pushed the feat/codebuild_step_cache branch from f710f95 to cb0eedd Compare June 2, 2022 12:49
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hi-Fi Thanks for making this change, complete with documentation and integ tests! We just need to have the conflicts resolved and I'll be happy to approve this change.

@Hi-Fi Hi-Fi force-pushed the feat/codebuild_step_cache branch from cb0eedd to 58e70a2 Compare June 15, 2022 13:32
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review June 15, 2022 13:32

Pull request has been modified.

@Hi-Fi Hi-Fi force-pushed the feat/codebuild_step_cache branch from 58e70a2 to 79d33ac Compare June 15, 2022 13:33
@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Jun 15, 2022

@Hi-Fi Thanks for making this change, complete with documentation and integ tests! We just need to have the conflicts resolved and I'll be happy to approve this change.

@TheRealAmazonKendra Rebased branch from main and fixed the conflicts

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 79d33ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 81ef665 into aws:main Jun 15, 2022
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Fixes aws#16375

Closes aws#19084

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdk.pipelines - Allow the configuration of Caching properties for Synth CodebuildProject
4 participants