Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): Migrate away from NODEJS_10_X and NODEJS_12_X to NODEJS_14_X #20595

Merged
merged 14 commits into from
Jun 3, 2022
Merged

feat(lambda): Migrate away from NODEJS_10_X and NODEJS_12_X to NODEJS_14_X #20595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
eac9470
feat(lambda): Migrate away from NODEJS_10_X and NODEJS_12_X to NODEJS…
robertd Jun 2, 2022
9bd5906
fix aws-sns-subscriptions
robertd Jun 2, 2022
e2cc615
fix aws-stepfunctions-tasks
robertd Jun 2, 2022
b768369
fix ecs-service-extensions
robertd Jun 2, 2022
f54a630
fix aws-msk
robertd Jun 2, 2022
4d51fd7
fix aws-glue
robertd Jun 2, 2022
7d501c0
fix even more stragglers
robertd Jun 3, 2022
a04dc74
more fixes
robertd Jun 3, 2022
ec22df8
more fixes
robertd Jun 3, 2022
4de0279
more fixes
robertd Jun 3, 2022
f8d8aaa
Merge branch 'main' into robertd/lambda
robertd Jun 3, 2022
8c9f563
revert prlint
robertd Jun 3, 2022
babbd4e
Merge branch 'main' into robertd/lambda
robertd Jun 3, 2022
e05f832
Merge branch 'main' into robertd/lambda
robertd Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion INTEGRATION_TESTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const stack = new cdk.Stack(app, 'aws-cdk-lambda-1');
const fn = new lambda.Function(stack, 'MyLambda', {
code: new lambda.InlineCode('foo'),
handler: 'index.handler',
runtime: lambda.Runtime.NODEJS_10_X,
runtime: lambda.Runtime.NODEJS_14_X,
});

app.synth();
Expand Down
6 changes: 3 additions & 3 deletions ...ers/ecs-service-extensions/test/assign-public-ip.integ.snapshot/aws-ecs-integ.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "17.0.0",
"version": "20.0.0",
"files": {
"8f06a3db22794ebc7ff89b4745fd706afd46e17816fe46da72e5125cabae725d": {
"source": {
Expand Down Expand Up @@ -40,15 +40,15 @@
}
}
},
"80aa78a4817ba118f8e03b489e7276a0100cd9dae8b7dd32db16e53b45d438b4": {
"0b2a2f517aed512c15790ab888051365faa60d6c56c60f963b9f68bd63700087": {
"source": {
"path": "aws-ecs-integ.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "80aa78a4817ba118f8e03b489e7276a0100cd9dae8b7dd32db16e53b45d438b4.json",
"objectKey": "0b2a2f517aed512c15790ab888051365faa60d6c56c60f963b9f68bd63700087.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...s/ecs-service-extensions/test/assign-public-ip.integ.snapshot/aws-ecs-integ.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@
}
},
"Handler": "framework.onEvent",
"Runtime": "nodejs12.x",
"Runtime": "nodejs14.x",
"Timeout": 900
},
"DependsOn": [
Expand Down Expand Up @@ -1279,7 +1279,7 @@
]
},
"Handler": "index.handler",
"Runtime": "nodejs12.x",
"Runtime": "nodejs14.x",
"Timeout": 120
},
"DependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion ...s/@aws-cdk-containers/ecs-service-extensions/test/assign-public-ip.integ.snapshot/cdk.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"17.0.0"}
{"version":"20.0.0"}
14 changes: 14 additions & 0 deletions ...aws-cdk-containers/ecs-service-extensions/test/assign-public-ip.integ.snapshot/integ.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"version": "20.0.0",
"testCases": {
"integ.assign-public-ip": {
"stacks": [
"aws-ecs-integ"
],
"diffAssets": false,
"stackUpdateWorkflow": true
}
},
"synthContext": {},
"enableLookups": false
}
7 changes: 2 additions & 5 deletions ...-cdk-containers/ecs-service-extensions/test/assign-public-ip.integ.snapshot/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "17.0.0",
"version": "20.0.0",
"artifacts": {
"Tree": {
"type": "cdk:tree",
Expand Down Expand Up @@ -146,10 +146,7 @@
"/aws-ecs-integ/name-task-definition/Resource": [
{
"type": "aws:cdk:logicalId",
"data": "nametaskdefinition690762BB",
"trace": [
"!!DESTRUCTIVE_CHANGES: WILL_REPLACE"
]
"data": "nametaskdefinition690762BB"
}
],
"/aws-ecs-integ/name-task-definition/ExecutionRole/Resource": [
Expand Down
Loading