Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): deprecate Python3.6 (#19988) #20647

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

RomainMuller
Copy link
Contributor

Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

@gitpod-io
Copy link

gitpod-io bot commented Jun 7, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 7, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 7, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 7, 2022 10:57
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

# Conflicts:
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/aws-cdk-eks-cluster-alb-controller-test.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/awscdkeksclusteralbcontrollertestawscdkawseksKubectlProviderA1AC28D1.nested.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-lambda/test/function.test.ts
#	packages/@aws-cdk/aws-lambda/test/runtime.inlinecode.integ.snapshot/aws-cdk-lambda-runtime-inlinecode.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/aws-stepfunctions-tasks-emr-containers-start-job-run-integ-test.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/awsstepfunctionstasksemrcontainersstartjobrunintegtestawscdkawseksKubectlProviderC26A0FC7.nested.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/lambda/invoke-function.integ.snapshot/integ.json
#	packages/@aws-cdk/lambda-layer-awscli/test/awscli-layer.integ.snapshot/lambda-layer-awscli-integ-stack.template.json
@RomainMuller RomainMuller force-pushed the huijbers/deprecate-python-3.6 branch from b78df0a to 404af24 Compare June 7, 2022 11:21
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 404af24
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were previously merged in the v1 banch;

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8f5cd2 into main Jun 7, 2022
@mergify mergify bot deleted the huijbers/deprecate-python-3.6 branch June 7, 2022 12:50
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes aws#20085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): InstanceDrainHook is still using EOL python runtime
4 participants