Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicecatalog): ProductStackHistory does not accept nested directories #20688

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

wanjacki
Copy link
Contributor

@wanjacki wanjacki commented Jun 9, 2022

This small PR will allow users to use nested directories in the ProductStackHistory feature.
Fixes #20658


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 9, 2022

@github-actions github-actions bot added the p2 label Jun 9, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 9, 2022 18:26
@wanjacki wanjacki force-pushed the nested-history-directories branch from 9edf9a9 to bf59c10 Compare June 9, 2022 18:45
@wanjacki wanjacki force-pushed the nested-history-directories branch from bf59c10 to 7140ffe Compare June 9, 2022 18:52
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Jun 9, 2022
@kaizencc kaizencc changed the title fix(aws-servicecatalog): Allow users to use nested directories in the… fix(servicecatalog): ProductStackHistory does not accept nested directories Jun 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b3ad711
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d4fdb4e into aws:main Jun 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
…tories (aws#20688)

This small PR will allow users to use nested directories in the ProductStackHistory feature. 
Fixes aws#20658 

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-servicecatalog): Nested directories in the ProductStackHistory feature
3 participants