Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v78.0.0 #20856

Closed
wants to merge 1 commit into from

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jun 24, 2022

No description provided.

@aws-cdk-automation aws-cdk-automation added auto-approve pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jun 24, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jun 24, 2022

@github-actions github-actions bot added the p2 label Jun 24, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 24, 2022 09:06
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 47ab174
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 28, 2022

pkglint error:

@aws-cdk/aws-redshiftserverless: - [package-info/engines] engines.node should be ">= 14.15.0", is ">= 10.13.0 <13 || >=13.7.0" (fixable)

rix0rrr added a commit that referenced this pull request Jun 28, 2022
When we updated the minimum Node version, we did not update it
in the template that is used to stamp out new construct libraries
when new CFN namespaces are added to the spec.

Meaning every cfnspec update now fails because the new packages
fail `pkglint` validation.

Update the Node version in the template.

Closes #20856.
@rix0rrr rix0rrr closed this Jun 30, 2022
@rix0rrr rix0rrr deleted the bump-cfnspec-v1-main/v78.0.0 branch June 30, 2022 08:01
mergify bot pushed a commit that referenced this pull request Jun 30, 2022
When we updated the minimum Node version, we did not update it
in the template that is used to stamp out new construct libraries
when new CFN namespaces are added to the spec.

Meaning every cfnspec update now fails because the new packages
fail `pkglint` validation.

Update the Node version in the template.

Closes #20856.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Jun 30, 2022
When we updated the minimum Node version, we did not update it
in the template that is used to stamp out new construct libraries
when new CFN namespaces are added to the spec.

Meaning every cfnspec update now fails because the new packages
fail `pkglint` validation.

Update the Node version in the template.

Closes #20856.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit 4e52091)
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
When we updated the minimum Node version, we did not update it
in the template that is used to stamp out new construct libraries
when new CFN namespaces are added to the spec.

Meaning every cfnspec update now fails because the new packages
fail `pkglint` validation.

Update the Node version in the template.

Closes aws#20856.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants