-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cfnspec): cloudformation spec v78.0.0 #20856
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
auto-approve
pr-linter/exempt-test
The PR linter will not require test changes
pr-linter/exempt-integ-test
The PR linter will not require integ test changes
labels
Jun 24, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
pkglint error:
|
rix0rrr
added a commit
that referenced
this pull request
Jun 28, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes #20856.
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes #20856. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes #20856. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 4e52091)
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
When we updated the minimum Node version, we did not update it in the template that is used to stamp out new construct libraries when new CFN namespaces are added to the spec. Meaning every cfnspec update now fails because the new packages fail `pkglint` validation. Update the Node version in the template. Closes aws#20856. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-approve
p2
pr-linter/exempt-integ-test
The PR linter will not require integ test changes
pr-linter/exempt-test
The PR linter will not require test changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.