-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redshift): adds classic or elastic resize type option #21084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would a user want to use classic vs elastic? Without doing some research myself I am not sure. Can you add more information to this docstring to help the user make that decision? Depending on how complicated the answer it it might need a README update.
@corymhall I have added more information to the docstring. I hope it is ok like this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corymhall I have added more information to the docstring. I hope it is ok like this :)
Do you think it is worth adding a README section?
I think it could be useful, because the topic is quite complex. Or is it enough to link the official AWS docs there?
Thanks for making the update! I think this is much better! I think for the scope of this PR this is fine, but I'll add a backlog item to add a resizing section to the README since it looks like resizing is pretty complicated.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #19430.
Adds the property
classicResizing
property to theClusterProps
. If not set or set to false, elastic resizing is used.I feel like an entry in the README is not necessary. If it is ok, please add
pr-linter/exempt-readme
label to this PR.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license