fix(cli): --no-fail flag is ignored in favor of the enableDiffNoFail feature flag

[otaviomacedo]

The CLI doesn't distinguish between cdk diff --no-fail and just cdk diff. In both cases, it's taking the value of enableDiffNoFail feature flag to decide which status code to return.

Change the behavior to:

Is there a difference?	--fail (CLI option)	enableDiffNoFail (FF)	Return code
No	Don't care	Don't care	0
Yes	false	Don't care	0
Yes	true	Don't care	1
Yes	null	false	1
Yes	null	true	0

Fixes #19110.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mrgrain]

Is there a way to make this change without loosing the default value in cdk diff --help?

[otaviomacedo]

Is there a way to make this change without loosing the default value in cdk diff --help?

I don't think so. To get the value of the feature flag we need a Configuration; to build a Configuration, we need the argv; and the argv is produced after all these CLI options have been set.

[Naumel]

Kudos for the scenarios, by the time I was done reading them I got it, but it was a thoroughly confusing journey until then :-)

The option takes precedence in what the outcome is, unless it's not specified, and that is when the feature flag value matters.

[Naumel]

lgtm

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 09b3f20
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).