fix(bootstrap): remove image scanning configuration #21342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove image scanning configuration for the staging ECR repository. - Image Scanning Configuration in the bootstrap template causes problems in regions where image scanning is not available. - Scanning configuration at the repository level has been deprecated in favor of configuration at the registry level, which also allows more configuration (basic vs. enhanced scanning). Because of a bug in the ECR CloudFormation resource, removing the configuration value does not actually turn it off. Therefore, for people who have successfully bootstrapped in the past, the scanning feature will be left as-is.
rix0rrr
added
the
pr-linter/exempt-test
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
approved these changes
Jul 27, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
2 tasks
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
Remove image scanning configuration for the staging ECR repository. - Image Scanning Configuration in the bootstrap template causes problems in regions where image scanning is not available. - Scanning configuration at the repository level has been deprecated in favor of configuration at the registry level, which also allows more configuration (basic vs. enhanced scanning). Because of a bug in the ECR CloudFormation resource, removing the configuration value does not actually turn it off. Therefore, for people who have successfully bootstrapped in the past, the scanning feature will be left as-is. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
|
FYI Security Hub ECR.1 flags the registry if you don't have image scanning enabled. So for first time CDK users, don't be surprised if you got a visit from your security team because CDK doesn't enable imaging scanning by default anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove image scanning configuration for the staging ECR repository.
in regions where image scanning is not available.
favor of configuration at the registry level, which also allows more
configuration (basic vs. enhanced scanning).
Because of a bug in the ECR CloudFormation resource, removing the
configuration value does not actually turn it off. Therefore, for
people who have successfully bootstrapped in the past, the scanning
feature will be left as-is.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license