Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): FunctionUrl incorrectly uses Alias ARNs #21351

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

RomainMuller
Copy link
Contributor

When configuring a FunctionUrl for a Lambda function Alias,
the underlying lambda function's ARN must be configured
as TargetFunctionArn, and the alias name as Qualifier. This
was previously not the case, as the Alias' ARN was used
with no qualifier, which accidentally succeeded provisionning
but did not necessarily produce the intended result.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

When configuring a FunctionUrl for a Lambda function Alias,
the underlying lambda function's ARN must be configured
as TargetFunctionArn, and the alias name as Qualifier. This
was previously not the case, as the Alias' ARN was used
with no qualifier, which accidentally succeeded provisionning
but did not necessarily produce the intended result.
@RomainMuller RomainMuller requested a review from a team July 28, 2022 10:41
@RomainMuller RomainMuller self-assigned this Jul 28, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jul 28, 2022

@github-actions github-actions bot added the p2 label Jul 28, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 28, 2022 10:41
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 28, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8ef344f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f34d60 into v1-main Jul 28, 2022
@mergify mergify bot deleted the rmuller/lambda-url-with-alias-v1 branch July 28, 2022 13:10
@HBobertz HBobertz mentioned this pull request Nov 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants