Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): Check type for Rule.props.schedule #21421

Closed
wants to merge 1 commit into from

Conversation

arewa
Copy link
Contributor

@arewa arewa commented Aug 2, 2022

This PR is fixing the issue #21055 by making additional check props.schedule is the Schedule type from the Events module when constructing the Rule.


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2022 17:23
@github-actions github-actions bot added the p2 label Aug 2, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 58a2057
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra
Copy link
Contributor

instanceof is not safe to use and we are disallowing the use of it per #20564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants