Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): firelens configFileValue is unnecessarily required (backport #20636) #21710

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix(ecs): firelens configFileValue is unnecessarily required (backport #20636) #21710

merged 2 commits into from
Aug 22, 2022

Commits on Aug 22, 2022

  1. fix(ecs): firelens configFileValue is unnecessarily required (#20636) 

    `FirelensOptions` should have only optional properties, but `configFileValue` was previously marked as required. This caused some confusion and incorrect configuration like `configFileValue = ''` as seen here: aws/aws-for-fluent-bit#352. This fix marks `configFileValue` as optional, and makes sure that `configFileValue` and `configFileType` are set together, or not at all. See [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-firelensconfiguration.html#cfn-ecs-taskdefinition-firelensconfiguration-options).

Signed-off-by: Wesley Pettit <wppttt@amazon.com>

Needed to fix: aws/aws-for-fluent-bit#352

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit b79b2e4)
    @PettitWesley @mergify
    PettitWesley authored and mergify[bot] committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    42c7178 View commit details
    Browse the repository at this point in the history

  2. update allowed breaking changes

    @kaizencc
    kaizencc committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a61153c View commit details
    Browse the repository at this point in the history