fix(core): feature flag values should be booleans #21759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FeatureFlags.isEnabled()` returns `boolean | undefined`, but if the
value of the feature flag is something other than a boolean, it will
actually return that type instead. For example,
```ts
node.setContext(someFeatureFlag, 'true');
const enabled = FeatureFlags.of(node).isEnabled(someFeatureFlag);
if (enabled) {
// will work
}
if (enabled === true) {
// will not work because enabled === 'true'
}
```
It looks like the only place this bug crops up is in the
`FunctionVersionUpgrade` aspect.
https://github.com/aws/aws-cdk/blob/8b0832334afee496355e7aeb684773d8f939f058/packages/@aws-cdk/aws-lambda/lib/function.ts#L1306
|
|
|
@Mergifyio update |
✅ Branch has been successfully updated |
Naumel
approved these changes
Aug 25, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
`FeatureFlags.isEnabled()` returns `boolean | undefined`, but if the
value of the feature flag is something other than a boolean, it will
actually return that type instead. For example,
```ts
node.setContext(someFeatureFlag, 'true');
const enabled = FeatureFlags.of(node).isEnabled(someFeatureFlag);
if (enabled) {
// will work
}
if (enabled === true) {
// will not work because enabled === 'true'
}
```
It looks like the only place this bug crops up is in the
`FunctionVersionUpgrade` aspect.
https://github.com/aws/aws-cdk/blob/8b0832334afee496355e7aeb684773d8f939f058/packages/@aws-cdk/aws-lambda/lib/function.ts#L1306
----
### All Submissions:
* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)
### Adding new Unconventional Dependencies:
* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)
### New Features
* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureFlags.isEnabled()returnsboolean | undefined, but if thevalue of the feature flag is something other than a boolean, it will
actually return that type instead. For example,
It looks like the only place this bug crops up is in the
FunctionVersionUpgradeaspect.aws-cdk/packages/@aws-cdk/aws-lambda/lib/function.ts
Line 1306 in 8b08323
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license