-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rds): marked deprecated version (in Cluster) #21828
chore(rds): marked deprecated version (in Cluster) #21828
Conversation
/** Version "5.7.12". */ | ||
/** | ||
* Version "5.7.12". | ||
* @deprecated Legacy Version no longer supported by Amazon RDS. Migrate to the available version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @deprecated Legacy Version no longer supported by Amazon RDS. Migrate to the available version. | |
* @deprecated Version 5.7.12 is no longer supported by Amazon RDS. |
Adding this suggestion in the one place but the pattern should be followed for each of these. Migrate to the available version.
isn't a helpful message here so we might as well omit it if we don't want to specify what it is, given the potential upkeep of that info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. I have generally reviewed all the messages with the policy you mentioned.
8e899e2
to
5a4b407
Compare
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The following corrections have been made
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license