Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): marked deprecated version (in Cluster) #21828

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

watany-dev
Copy link
Contributor

The following corrections have been made

  • Added comment on deprecated version
  • Added version that was omitted
  • Comment that was incorrect

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 30, 2022

@github-actions github-actions bot added the p2 label Aug 30, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2022 15:09
@watany-dev watany-dev changed the title chore(rds) marked-deprecated-version chore(rds): marked deprecated version (in Cluster) Aug 30, 2022
/** Version "5.7.12". */
/**
* Version "5.7.12".
* @deprecated Legacy Version no longer supported by Amazon RDS. Migrate to the available version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated Legacy Version no longer supported by Amazon RDS. Migrate to the available version.
* @deprecated Version 5.7.12 is no longer supported by Amazon RDS.

Adding this suggestion in the one place but the pattern should be followed for each of these. Migrate to the available version. isn't a helpful message here so we might as well omit it if we don't want to specify what it is, given the potential upkeep of that info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I have generally reviewed all the messages with the policy you mentioned.

@watany-dev watany-dev force-pushed the chore(rds)-marked-deprecated-version branch from 8e899e2 to 5a4b407 Compare August 30, 2022 23:32
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 30, 2022 23:33

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ec1dd58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 36484c3 into aws:main Aug 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the chore(rds)-marked-deprecated-version branch August 31, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants