Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): add propagate tags prop in job definition #21904

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

jmortlock
Copy link
Contributor

@jmortlock jmortlock commented Sep 2, 2022

Closes: #21740

Add support for propagateTags to the CDK construct.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 2, 2022 23:59
@github-actions github-actions bot added the p2 label Sep 2, 2022
@jmortlock
Copy link
Contributor Author

Linter is failing as it wants a README change, not sure if this property warrants that?

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is likely OK to not include a README update, but this is still going to fail on lack of integration tests. That we will need before we can approve/merge this.

* If no value is specified, the tags aren't propagated.
* Tags can only be propagated to the tasks during task creation. For tags with the same name,
* job tags are given priority over job definitions tags.
* If the total number of combined tags from the job and job definition is over 50, the job is moved to the `FAILED` state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this validation we can do at synth time instead of letting the job fail at deploy time? If so, it should be added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a way to get the tag count of a construct; the current Tag aspect API only offers the ability to add/remove tags. If you have any ideas happy to dig deeper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer, that's OK.

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 3, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(aws-batch): Add propagateTags to JobDefinition feat(batch): add propagate tags prop in job definition Sep 3, 2022
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review September 3, 2022 05:11

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9666a45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1bc4526 into aws:main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Batch: Need support for more JobDefinition attributes
3 participants