Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support for Docker in VS Code devcontainer #21909

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 3, 2022

The current devcontainer configuration doesn't support docker commands.

More details in this Slack Thread: https://cdk-dev.slack.com/archives/C018XT6REKT/p1661980670194059


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 3, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 3, 2022 15:54
@github-actions github-actions bot added the p2 label Sep 3, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 3, 2022
@misterjoshua
Copy link
Contributor

I tested these changes and they work on both my Ubuntu 22.04 LTS box and on another computer in Windows Subsystem for Linux.

@mrgrain
Copy link
Contributor Author

mrgrain commented Sep 3, 2022

Manually tested this new devcontainer on MacOS and WSL 2.0. They both work. 🚀

@TheRealAmazonKendra
Copy link
Contributor

There's no way I can ask for tests in code here, is there? I do wonder if this should be a feat just so it shows up in the changelog, even though we'll have to exempt tests and whatnot.

@mrgrain
Copy link
Contributor Author

mrgrain commented Sep 3, 2022

Excellent question. I did some research and find this https://code.visualstudio.com/docs/remote/devcontainer-cli
I think the question is more if it's worth the setup. I'm not sure if we have something similar at the moment.

Agreed on making it a feature and I'd like to make some changes to the contributing guide.

@mrgrain mrgrain changed the title chore: improved devcontainer feat: support for Docker in VS Code devcontainer Sep 5, 2022
@mrgrain
Copy link
Contributor Author

mrgrain commented Sep 5, 2022

@TheRealAmazonKendra I've decided against automated testing of this. The only thing we would gain from this is to know if the Dockerfile builds. Will add docs changes though.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@mrgrain mrgrain changed the title feat: support for Docker in VS Code devcontainer chore: support for Docker in VS Code devcontainer Oct 17, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 17, 2022 10:12

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mrgrain mrgrain marked this pull request as ready for review October 17, 2022 10:37
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipping! Not a big risk since it only effects local development.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 38fdfeb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b22182f into aws:main Oct 25, 2022
@mrgrain mrgrain deleted the devcontainer branch July 26, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants