-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support for Docker in VS Code devcontainer #21909
Conversation
I tested these changes and they work on both my Ubuntu 22.04 LTS box and on another computer in Windows Subsystem for Linux. |
Manually tested this new devcontainer on MacOS and WSL 2.0. They both work. 🚀 |
bd508d4
to
7d70930
Compare
There's no way I can ask for tests in code here, is there? I do wonder if this should be a feat just so it shows up in the changelog, even though we'll have to exempt tests and whatnot. |
Excellent question. I did some research and find this https://code.visualstudio.com/docs/remote/devcontainer-cli Agreed on making it a feature and I'd like to make some changes to the contributing guide. |
@TheRealAmazonKendra I've decided against automated testing of this. The only thing we would gain from this is to know if the Dockerfile builds. Will add docs changes though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shipping! Not a big risk since it only effects local development.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The current devcontainer configuration doesn't support docker commands.
More details in this Slack Thread: https://cdk-dev.slack.com/archives/C018XT6REKT/p1661980670194059
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license