Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(certificatemanager): deprecate DnsValidatedCertificate #21982

Merged
merged 7 commits into from
Jan 25, 2023
Merged

feat(certificatemanager): deprecate DnsValidatedCertificate #21982

merged 7 commits into from
Jan 25, 2023

Commits on Jan 23, 2023

  1. feat(certificatemanager): deprecate DnsValidatedCertificate

    Now that the official CloudFormation resource `AWS::CertificateManager::Certificate`
    (CDK's `Certificate` construct) supports DNS validation we do not want
    to recommend using the `DnsValidatedCertificate` construct.
    
    The `DnsValidatedCertificate` construct uses CloudFormation custom
    resources to perform the certificate creation and this creates a lot of
    maintenance burden on our team (see the list of linked issues).
    Currently the primary use case for using `DnsValidatedCertificate` over
    `Certificate` is for cross region use cases. For this use case I have
    updated the README to have our suggested solution.
    
    fixes #8934, #2914, #20698, #17349, #15217, #14519
    corymhall committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b0bffcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0375e5 View commit details
    Browse the repository at this point in the history
  3. updating tests and README

    corymhall committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f5489f5 View commit details
    Browse the repository at this point in the history
  4. updating readme

    corymhall committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    11f5a9b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    ec42075 View commit details
    Browse the repository at this point in the history
  2. fixing docs

    corymhall committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    52c9d38 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    2e4e47c View commit details
    Browse the repository at this point in the history