Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integ-tests): chain assertion api calls #22196

Merged
merged 5 commits into from
Sep 23, 2022
Merged

feat(integ-tests): chain assertion api calls #22196

merged 5 commits into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. feat(integ-tests): chain assertion api calls

    This PR does two things.
    
    1. Adds a helper method `then()` that makes it easier to chain assertion
       api calls together. Yes, it is possible to grab the underlying `node`
       and call `addDependency`, but I think `then` is a more intuitive
       experience.
    
    Look at `integ.log-group.ts` to see where I updated a test from
    `addDependency` -> `then`
    
    2. Added an `ApiCallBase` class and renamed the api call interface. This
       will make it easier to add more types of Api Calls in the future
       (`HttpApiCall` coming soon*)
    corymhall committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2b62967 View commit details
    Browse the repository at this point in the history
  2. fixing rosetta failures

    corymhall committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4177301 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. changing then -> next

    corymhall committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    89d26be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23135dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59b46b2 View commit details
    Browse the repository at this point in the history