Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fixed package versions in integ tests #22360

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 5, 2022

When running the integ tests we install a bunch of packages that are necessary just for the tests. We indiscriminately install the latest versions, and now axios has released a new MV with breaking changes, so our tests fail.

Install known versions for all of them.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

When running the integ tests we install a bunch of packages that are
necessary just for the tests. We indiscriminately install the latest
versions, and now `axios` has released a new MV with breaking changes,
so our tests fail.

Install known versions for all of them.
@rix0rrr rix0rrr requested a review from a team October 5, 2022 08:16
@rix0rrr rix0rrr self-assigned this Oct 5, 2022
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 5, 2022
@Naumel
Copy link
Contributor

Naumel commented Oct 5, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

update

✅ Branch has been successfully updated

@gitpod-io
Copy link

gitpod-io bot commented Oct 5, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team October 5, 2022 08:20
@github-actions github-actions bot added the p2 label Oct 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e9dd1ab into main Oct 5, 2022
@mergify mergify bot deleted the huijbers/prevent-upgrade branch October 5, 2022 08:59
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3dada99
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr added a commit that referenced this pull request Oct 6, 2022
When running the integ tests we install a bunch of packages that are necessary just for the tests. We indiscriminately install the latest versions, and now `axios` has released a new MV with breaking changes, so our tests fail.

Install known versions for all of them.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
arewa pushed a commit to arewa/aws-cdk that referenced this pull request Oct 8, 2022
When running the integ tests we install a bunch of packages that are necessary just for the tests. We indiscriminately install the latest versions, and now `axios` has released a new MV with breaking changes, so our tests fail.

Install known versions for all of them.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@HBobertz HBobertz mentioned this pull request Nov 10, 2022
4 tasks
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
When running the integ tests we install a bunch of packages that are necessary just for the tests. We indiscriminately install the latest versions, and now `axios` has released a new MV with breaking changes, so our tests fail.

Install known versions for all of them.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants