-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): Vpc supports allocating CIDR from AWS IPAM #22458
Conversation
This looks sensible, however i'd urge care here that this does not cause unintended breaking changes. I noted that Network Builder as been removed, and replaced with IPAMProvider. There are many cases where someone is not going to use IPAM. Its confusing to use the term IPAM, when the IPAM service is not part of things doesn't make sense. Its not the job of 'IPAM' to calculate subnets.. Its the job of IPAM to assign Pools of Address space, ( and monitor them ).. NetworkBuilder was not a bad name, becuase it described what it was doing.. IPAM is not a good name. |
I have some final commits pushed to Neil's branch, but they're not appearing here. Can't approve until I see them and I know they are in the validation pipeline. |
…into pr/nbaillie/22458
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sorry a late comment, but only about docs. Something that might cause pain , is if we try to request an ipam allocation from a pool that has rules applied to it, restricting which size networks are able to be allocated. eg, if you asked for a /20 but the rules say you can only have between /22 - /24. A once sentance addtion could save a lot of fustration. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you very much for this. We have been stuck with L1 constructs only until now; this change now makes CDK a usable and useful product for us to replace raw CloudFormation! |
Allows Vpc to Use Aws IPAM for Ip address assignment:
This is useful for enterprise users that wish to adopt the benefits of centralised IP address management.
It introduces
ipAddresses
property to allow the new configuration.Thanks to @rix0rrr for support on this.
closes #21333
#22443 - Issue adds a fix to allow the clean up of the AWS Ipam resource used in ingeg-test testing. Would be better to implement something like this later. for now disclaimer added to integ-test clean up needed on Ipam.
All Submissions:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license