Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): adding a circuit breaker causes Service replacement (under feature flag) #22467

Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8464201
Backwards-compatible implementation with tests
Oct 12, 2022
51e6b37
update integration test
Oct 12, 2022
6c19367
Update packages/@aws-cdk/aws-ecs/lib/base/base-service.ts
fergusdixon Oct 19, 2022
02192e1
create new test
Oct 19, 2022
28801f2
revert old snapshot changes
Oct 19, 2022
21c3859
implement feature flag, some old integration tests failing
Oct 25, 2022
b177682
fix error annotation
Oct 25, 2022
5aa23fb
set old integration tests too old behaviour
Oct 25, 2022
de2cc2a
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Oct 26, 2022
b2df8de
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Oct 28, 2022
f8daa6d
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Oct 31, 2022
975c6de
use feature flags in old integ tests
Oct 31, 2022
d22be52
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Oct 31, 2022
d2bcfa4
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Nov 1, 2022
3723d3e
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
fergusdixon Nov 3, 2022
66f2036
remove useExplicitEcsDeploymentController option to only rely on feat…
Nov 3, 2022
0a4a8a0
add snapshot
Nov 3, 2022
552e5e8
remove old snapshot
Nov 3, 2022
deb9800
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
Nov 7, 2022
94117ee
add auto-built readme line
Nov 7, 2022
2f72339
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
Nov 8, 2022
1500b74
rebuild feature flags
Nov 8, 2022
f65b647
Merge branch 'main' into fix/remove-explicit-ecs-deployment-type-for-…
mergify[bot] Nov 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Vpc } from '@aws-cdk/aws-ec2';
import { Cluster, ContainerImage } from '@aws-cdk/aws-ecs';
import { App, Stack } from '@aws-cdk/core';
import * as cxapi from '@aws-cdk/cx-api';
import * as integ from '@aws-cdk/integ-tests';
import { ApplicationLoadBalancedFargateService } from '../../lib';

const app = new App();
const app = new App({ postCliContext: { [cxapi.ECS_DISABLE_EXPLICIT_DEPLOYMENT_CONTROLLER_FOR_CIRCUIT_BREAKER]: false } });
const stack = new Stack(app, 'aws-ecs-integ-circuit-breaker');
const vpc = new Vpc(stack, 'Vpc', { maxAzs: 2 });
const cluster = new Cluster(stack, 'Cluster', { vpc });
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "21.0.0",
"files": {
"4eec79ee498cc4b9ae0a8ad419511759b90d72d3a3cb5bd018e5e137f050cfae": {
"source": {
"path": "aws-ecs-integ-circuit-breaker-no-dc.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "4eec79ee498cc4b9ae0a8ad419511759b90d72d3a3cb5bd018e5e137f050cfae.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Loading