Simple heuristics to determine python executable name across platforms #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garnaat
added
bug
eladb
approved these changes
Apr 11, 2019
packages/aws-cdk/lib/init.ts
Outdated
| } | ||
| print('Unable to create virtualenv automatically'); | ||
| print(`Please run ${colors.green('python3 -m venv .env')}!`); | ||
| } |
packages/aws-cdk/lib/init.ts
Outdated
| throw new Error(`${colors.green('python3 -m venv .env')} failed: ` + e.message); | ||
| } | ||
| print('Unable to create virtualenv automatically'); | ||
| print(`Please run ${colors.green('python3 -m venv .env')}!`); |
There was a problem hiding this comment.
replace "python3" with python
…ion problem. Clarify some things in README files.
eladb
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181.
Added a simple function that determines Python executable name depending on underlying platform. Changed a number of init templates to take advantage of that.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.