Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to use JSII 0.9.0 #2255

Merged
merged 1 commit into from
Apr 12, 2019
Merged

chore: update to use JSII 0.9.0 #2255

merged 1 commit into from
Apr 12, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 12, 2019

Update dependency versions in the right places, update docstrings to
comply with new, stricter standards, update awslint to use new
jsii-reflect API.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr
chore: update to use JSII 0.9.0
c1c65dc 
Update dependency versions in the right places, update docstrings to
comply with new, stricter standards, update awslint to use new
jsii-reflect API.
@rix0rrr rix0rrr requested review from RomainMuller, skinny85, SoManyHs and a team as code owners April 12, 2019 12:08
RomainMuller
RomainMuller approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should note that this is effectively a BREAKING CHANGE.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 12, 2019

Should note that this is effectively a BREAKING CHANGE.

In what way?

@rix0rrr rix0rrr merged commit b617078 into master Apr 12, 2019
@rix0rrr rix0rrr deleted the huijbers/bump-jsii branch April 12, 2019 14:43
rix0rrr added a commit that referenced this pull request Apr 15, 2019
@rix0rrr
Revert "chore: update to use JSII 0.9.0 (#2255)"
e335a67 
This reverts commit b617078.
rix0rrr added a commit that referenced this pull request Apr 15, 2019
@rix0rrr
Revert "chore: update to use JSII 0.9.0 (#2255)" (#2265)
d72806b 
Revert JSII 0.9.0 upgrade.

JSII 0.9.0 dotnet code generation is broken for assemblies that contain 
custom doc attributes.

This reverts commit b617078.
rix0rrr added a commit that referenced this pull request Apr 17, 2019
@rix0rrr
chore: update to use JSII 0.9.0 (#2255)
74d5871 
Update dependency versions in the right places, update docstrings to
comply with new, stricter standards, update awslint to use new
jsii-reflect API.

BREAKING CHANGE: you will not be able to combine jsii libraries written
against previous versions of jsii with this version of the CDK.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

@skinny85 skinny85 Awaiting requested review from skinny85

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @RomainMuller @NGL321