Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(apigateway): Enclose getaway response parameters within single quotes #22637

Merged
merged 2 commits into from
Oct 25, 2022
Merged

refactor(apigateway): Enclose getaway response parameters within single quotes #22637

merged 2 commits into from
Oct 25, 2022

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Oct 25, 2022 •
edited
Loading

Hi team,

Here is a follow up to #22633

Please let me know if this makes sense.
Thanks

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2022

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 25, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 25, 2022 16:42
@github-actions github-actions bot added the p2 label Oct 25, 2022
@yuyokk yuyokk mentioned this pull request Oct 25, 2022
Merged
1 task
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(apigateway): Enclose getaway response parameters within single quotes refactor(apigateway): Enclose getaway response parameters within single quotes Oct 25, 2022
@TheRealAmazonKendra
Copy link
Contributor

This isn't really a fix since it wasn't reaaaaally a bug, just a bad user experience.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 25, 2022 19:20

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9f2907
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fc9e142 into aws:main Oct 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yuyokk yuyokk deleted the enclose-value-into-single-quotes branch October 25, 2022 21:36
@CaerusKaru CaerusKaru mentioned this pull request Nov 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 22, 2022
@CaerusKaru
Revert: "refactor(apigateway): Enclose getaway response parameters wi…
dc8f87a 
…thin single quotes" (#23037)

Reverts #22637

This is because single quotes are _not_ desirable if you're using [context variables](https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-gatewayResponse-definition.html), which must be provided without quotes.
@grmorozov grmorozov mentioned this pull request Nov 27, 2022
Closed
@grmorozov
Copy link

grmorozov commented Nov 27, 2022 •
edited
Loading

The changes in this PR led to the broken functionality. The are cases, when response parameter values should not be quoted. I opened a new issue to address this.

@yuyokk
Copy link
Contributor Author

yuyokk commented Nov 27, 2022

@grmorozov changes were already reverted here #23037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuyokk @TheRealAmazonKendra @aws-cdk-automation @grmorozov