feat(eks): support for Kubernetes version 1.23 #22638

kaizencc · 2022-10-25T19:28:18Z

Add support for Kubernetes Version 1.23. In order to use this version, customers must pass in a KubectlLayer object from @aws-cdk/lambda-layer-kubectl-v23 to the kubectlLayer construct prop of Cluster.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The EKS Cluster construct has a property called `kubectlLayer`. When this property was not given, it would add a two default layers to the custom resource: - One with kubectl - One with the AWS CLI However, if the property was given, the one layer must contain both kubectl as well as the AWS CLI. This makes the `kubectl` layer unnecessarily large -- it must also contain the AWS CLI which the CDK already has and can bundle itself. Add a separate `awscliLayer` parameter to control the AWS CLI layer, if the user so wants. If not, the default AWS CLI layer will be added. If some user is already using a `kubectlLayer` which includes the AWS CLI, we now add both the default AWS CLI layer as well as the user's kubectl layer with the AWS CLI in it. There is no conflict: multiple layers can contain the same files. Last layer wins (which is the kubectl layer with the user's preferred AWS CLI).

Co-authored-by: Eli Polonsky <epolon@amazon.com>

…ws-cdk into huijbers/eks-separate-awscli-layer

gitpod-io · 2022-10-25T19:28:31Z

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

…ation tests

packages/@aws-cdk/aws-eks/package.json

TheRealAmazonKendra · 2022-10-25T20:23:54Z

PR Linter has words for you.

…oy/eks

kaizencc · 2022-10-27T14:04:25Z

readme exempt; this is a feature for a new version and the method to include new kubectl versions is already included in the readme.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

…oy/eks

robertd · 2022-10-27T17:08:03Z

@pahud We need MVP awards/recognition for each release. I nominate @madeline-k & @kaizencc for the upcoming v2.48.0 release 😃 🎉 🚀

madeline-k

This looks good to me and has my approval! I am not going to officially approve, as I am now a significant co-author, and I'd like someone else in the team to approve.

TheRealAmazonKendra · 2022-10-27T17:38:06Z

packages/@aws-cdk/aws-eks/lib/cluster.ts

-      Annotations.of(this).addWarning(`You created a cluster with Kubernetes Version ${props.version} without specifying the kubectlLayer property. This may cause failures as the kubectl version provided with aws-cdk-lib is 1.20, which is only guaranteed to be compatible with Kubernetes versions 1.19-1.21. Please provide a kubectlLayer from @aws-cdk/lambda-layer-kubectl-v22.`);
+    const kubectlVersion = Number(props.version.version) * 100;
+    if (kubectlVersion >= 122 && !props.kubectlLayer) {
+      Annotations.of(this).addWarning(`You created a cluster with Kubernetes Version ${props.version.version} without specifying the kubectlLayer property. This may cause failures as the kubectl version provided with aws-cdk-lib is 1.20, which is only guaranteed to be compatible with Kubernetes versions 1.19-1.21. Please provide a kubectlLayer from @aws-cdk/lambda-layer-kubectl-v${kubectlVersion % 100}.`);


Is it that it may cause errors or that it will? If we know it will, I think this should be an error.

If not, no issues here.

It is not for certain. In some cases you can use a version of kubectl that is not guaranteed to be compatible with the version of the Kubernetes engine you are using. It just depends on the APIs being used.

TheRealAmazonKendra · 2022-10-27T17:38:42Z

packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/manifest.json

-            "data": "KubectlLayer600207B5"
+            "data": "KubectlLayer600207B5",
+            "trace": [
+              "!!DESTRUCTIVE_CHANGES: WILL_REPLACE"


Is this a concern?

No, a lambda layer is a stateless resource, and we are replacing it with an upgraded version of kubectl. So, the replacement is expected here.

MrArnoldPalmer

just a small suggestion

packages/@aws-cdk/aws-eks/lib/cluster.ts

aws-cdk-automation · 2022-10-27T19:03:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 97281d2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-10-27T19:14:58Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

rix0rrr and others added 16 commits October 19, 2022 15:40

Tests

d1e4a58

Update packages/@aws-cdk/aws-eks/lib/cluster.ts

d184727

Co-authored-by: Eli Polonsky <epolon@amazon.com>

Snapshots some more

3e985be

Merge branch 'huijbers/eks-separate-awscli-layer' of github.com:aws/a…

4c1b57b

…ws-cdk into huijbers/eks-separate-awscli-layer

Tests

0696a37

Snapshots some more

f1a484a

Update cluster.ts

9892f6a

Merge branch 'main' into huijbers/eks-separate-awscli-layer

e821907

feat(eks): support for Kubernetes version 1.22

a0b1d71

Remove residual integration test files

6ebd1b6

update README and version number

4e8c7ee

update readme

888db08

integration tests

b782726

Merge branch 'main' into madeline-k/kubernetes-v22

7bf6b0d

feat(eks): support for Kubernetes version 1.23

11bf39e

github-actions bot added the p2 label Oct 25, 2022

kaizencc changed the title ~~Conroy/kubernetes v23~~ feat(eks): support for Kubernetes version 1.23 Oct 25, 2022

aws-cdk-automation requested a review from a team October 25, 2022 19:28

kaizencc changed the base branch from main to madeline-k/kubernetes-v22 October 25, 2022 19:28

mergify bot added the contribution/core This is a PR that came from AWS. label Oct 25, 2022

aws-cdk-automation previously requested changes Oct 25, 2022

View reviewed changes

kaizencc and others added 3 commits October 25, 2022 15:32

minor version

9f9db94

add latest aws-cdk-lib to devDependencies so it can be used in integr…

67da92b

…ation tests

revert

cdf5d1d

kaizencc commented Oct 25, 2022

View reviewed changes

packages/@aws-cdk/aws-eks/package.json Show resolved Hide resolved

kaizencc and others added 2 commits October 25, 2022 15:47

Merge branch 'madeline-k/kubernetes-v22' into conroy/kubernetes-v23

9d89f1a

kubectlv23

bfa8d82

kaizencc and others added 6 commits October 27, 2022 08:39

fargate cluster snapshot

6d961b5

yarn.lock file

cb1b11e

Merge branch 'conroy/eks' of https://github.com/aws/aws-cdk into conr…

cc477ce

…oy/eks

cluster handlers vpc snapshot

c3461ba

alb controller

10d85ba

Merge branch 'main' into conroy/eks

b9622a9

kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 27, 2022

kaizencc and others added 4 commits October 27, 2022 12:00

stepfunctions-tasks snapshot updates

fbf9939

Merge branch 'conroy/eks' of https://github.com/aws/aws-cdk into conr…

930212d

…oy/eks

Merge branch 'main' into conroy/eks

af3362c

Merge branch 'conroy/eks' into conroy/kubernetes-v23

84c7e9e

Base automatically changed from conroy/eks to main October 27, 2022 16:40

madeline-k added 2 commits October 27, 2022 09:45

merge conflicts

cba6fe2

Merge branch 'main' into conroy/kubernetes-v23

6dc385e

madeline-k reviewed Oct 27, 2022

View reviewed changes

TheRealAmazonKendra reviewed Oct 27, 2022

View reviewed changes

MrArnoldPalmer requested changes Oct 27, 2022

View reviewed changes

packages/@aws-cdk/aws-eks/lib/cluster.ts Outdated Show resolved Hide resolved

use semver

97281d2

madeline-k requested review from MrArnoldPalmer and TheRealAmazonKendra October 27, 2022 18:38

MrArnoldPalmer approved these changes Oct 27, 2022

View reviewed changes

TheRealAmazonKendra approved these changes Oct 27, 2022

View reviewed changes

madeline-k approved these changes Oct 27, 2022

View reviewed changes

mergify bot merged commit 4e858f2 into main Oct 27, 2022

mergify bot deleted the conroy/kubernetes-v23 branch October 27, 2022 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eks): support for Kubernetes version 1.23 #22638

feat(eks): support for Kubernetes version 1.23 #22638

kaizencc commented Oct 25, 2022 •

edited by madeline-k

Loading

gitpod-io bot commented Oct 25, 2022

aws-cdk-automation left a comment

TheRealAmazonKendra commented Oct 25, 2022

kaizencc commented Oct 27, 2022

robertd commented Oct 27, 2022

madeline-k left a comment

TheRealAmazonKendra Oct 27, 2022

TheRealAmazonKendra Oct 27, 2022

madeline-k Oct 27, 2022

TheRealAmazonKendra Oct 27, 2022

madeline-k Oct 27, 2022

MrArnoldPalmer left a comment

aws-cdk-automation commented Oct 27, 2022

mergify bot commented Oct 27, 2022

feat(eks): support for Kubernetes version 1.23 #22638

feat(eks): support for Kubernetes version 1.23 #22638

Conversation

kaizencc commented Oct 25, 2022 • edited by madeline-k Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Oct 25, 2022

aws-cdk-automation left a comment

Choose a reason for hiding this comment

TheRealAmazonKendra commented Oct 25, 2022

kaizencc commented Oct 27, 2022

robertd commented Oct 27, 2022

madeline-k left a comment

Choose a reason for hiding this comment

TheRealAmazonKendra Oct 27, 2022

Choose a reason for hiding this comment

TheRealAmazonKendra Oct 27, 2022

Choose a reason for hiding this comment

madeline-k Oct 27, 2022

Choose a reason for hiding this comment

TheRealAmazonKendra Oct 27, 2022

Choose a reason for hiding this comment

madeline-k Oct 27, 2022

Choose a reason for hiding this comment

MrArnoldPalmer left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Oct 27, 2022

AWS CodeBuild CI Report

mergify bot commented Oct 27, 2022

kaizencc commented Oct 25, 2022 •

edited by madeline-k

Loading