Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integ-runner): support custom --test-regex to match integ test files #22786

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 4, 2022

Follow-up to #22761. To support other languages than JavaScript (see #22521) we need to be able to detect test files with any patterns. With this PR, users can specify a number of custom --test-regex patterns that will bed used to discover integration test files. Together with --app this can already be used to run integ tests in arbitrary languages.

Example usage: integ-runner --app="python3 {filePath}" --test-regex="^integ_.*\.py$"

Also contains a minor refactor to make --app available via IntegrationTests.fromFile(). This is in preparation of an upcoming change to reestablish support for an integration test config file.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 4, 2022

@github-actions github-actions bot added the p2 label Nov 4, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 4, 2022 15:41
@mrgrain mrgrain added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 labels Nov 4, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 4, 2022
@mrgrain mrgrain force-pushed the mrgrain/feat/21169-integ-test-test-regex branch from e1a1801 to 685b1de Compare November 7, 2022 12:34
@mrgrain mrgrain marked this pull request as ready for review November 7, 2022 12:34
@github-actions github-actions bot added the p2 label Nov 7, 2022
@mrgrain mrgrain force-pushed the mrgrain/feat/21169-integ-test-test-regex branch 2 times, most recently from 68f6cea to 3b36ce8 Compare November 7, 2022 15:50
mrgrain and others added 2 commits November 7, 2022 16:47
@mrgrain mrgrain force-pushed the mrgrain/feat/21169-integ-test-test-regex branch from 3b36ce8 to fd350bb Compare November 7, 2022 16:49
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Nov 7, 2022
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2022
@corymhall corymhall added the pr/do-not-merge This PR should not be merged at this time. label Nov 10, 2022
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion, feel free to remove the do-not-merge label.

packages/@aws-cdk/integ-runner/test/cli.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Nov 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: daba17f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fa1a439 into aws:main Nov 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain deleted the mrgrain/feat/21169-integ-test-test-regex branch July 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants