Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bootstrap arguments for permissions boundary #22792
feat: bootstrap arguments for permissions boundary #22792
Changes from 32 commits
e2db370
2353ce9
302d4dc
8cea87e
3749a90
767755b
efc8653
074450b
09c2bff
82101af
35f922a
c102960
defeea8
8961c3b
d47e3b5
9d5e667
ee95f76
3ddfade
a52f790
396cf32
ccd90f7
ea88b89
1debcdf
157415c
e75869f
96a8f64
303ba4d
3823e1e
2fa9d19
bd7fbc2
0745549
dbf096c
3a660ee
0b994a0
1e7d1bd
8e29fb7
58510fc
7f03db2
16cf026
79ecf77
7669755
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, looks like the policy is valid from CloudFormations perspective because it
contains CloudFormation intrinsics which doesn't work with the IAM API. Not sure
if it would be easier to do a Regex replacement or just manage the policy in two
places? I would be fine managing it in two places if that is easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds more heavy-duty -- can I open a follow-up for that POC and switch back to the policy doc as string for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Naumel @corymhall just curious, should the CdkBootstrapVersion be also updated as part of this change? (i.e. When do we increment this version?)
We're currently encountering an issue in our bootstrap stacks where:
Previously, we would encounter a warning:
that would prevent developers using an outdated CDK toolkit from downgrading the toolkit stack.
Wondering if this was the cause