fix(iam): service principals use unnecessary exceptions (under feature flag) #22819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e flag)
We have a database of service principal exceptions in different regions.
This database is no longer necessary: all services now use the global
service principal name for in-region references, and sometimes a
standardized regional service principal name for cross-opt-in-region
references.
This PR changes the following things:
```ts
new ServicePrincipal('service.amazonaws.com')
// ➡️ always resolves to 'service.amazonaws.com', regardless of region
// or service principal
new ServicePrincipal('service.amazonaws.com', { region: 'me-south-1' })
// ➡️ resolves to 'service.me-south-1.amazonaws.com' in case of a
// cross-region reference, or just 'service.amazonaws.com' otherwise.
```
Because change is scary (and because we are only 99% sure that this
change has made it to all ADC regions), we put the new behavior behind a
feature flag:
```json
{
"context": {
"@aws-cdk/aws-iam:standardizedServicePrincipals": true
}
}
```
|
|
|
(This change will break many snapshots -- I'm working on it) |
aws-cdk-automation
previously requested changes
Nov 7, 2022
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
rix0rrr
force-pushed
the
huijbers/standardize-sps
branch
from
76846de to
622a2cd
Compare
aws-cdk-automation
previously requested changes
Nov 9, 2022
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
jpignata
added a commit
to jpignata/aws-cdk
that referenced
this pull request
Nov 23, 2022
In aws#22819, a feature flag was added to use standardized service principal names instead of using a database lookup. This reference wasn't updated which causes failures in new CDK applications that try to create AppSync resources. This change passes the fully qualified service principal when creating a service role for a new data source. fixes aws#23035
jpignata
added a commit
to jpignata/aws-cdk
that referenced
this pull request
Nov 23, 2022
In aws#22819, a feature flag was added to use standardized service principal names instead of using a database lookup. This reference wasn't updated which causes failures in new CDK applications that try to create AppSync resources. This change passes the fully qualified service principal when creating a service role for a new data source. fixes aws#23035
jpignata
added a commit
to jpignata/aws-cdk
that referenced
this pull request
Nov 23, 2022
In aws#22819, a feature flag was added to use standardized service principal names instead of using a database lookup. This reference wasn't updated which causes failures in new CDK applications that try to create AppSync resources. This change passes the fully qualified service principal when creating a service role for a new data source. fixes aws#23035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a database of service principal exceptions in different regions.
This database is no longer necessary: all services now use the global service principal name for in-region references, and sometimes a standardized regional service principal name for cross-opt-in-region references.
This PR changes the following things:
Because change is scary (and because we are only 99% sure that this change has made it to all ADC regions), we put the new behavior behind a feature flag:
{ "context": { "@aws-cdk/aws-iam:standardizedServicePrincipals": true } }By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license