Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(logs-destinations): correctly set package description in README #22839

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 9, 2022

The README uses a "for AWS XXX" description as the main header. This updates that header
to match the format used for the Kinesis Destinations and Lambda Destinations libraries.

This is a backport of #21570 to v1


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 9, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2022 11:38
@github-actions github-actions bot added the p2 label Nov 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 9, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 88b1a7d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9be5ff7 into v1-main Nov 9, 2022
@mergify mergify bot deleted the mrgrain/chore/aws-logs-destinations-title branch November 9, 2022 12:23
@HBobertz HBobertz mentioned this pull request Nov 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants