fix(integ-runner): asset hashes of nested stack templates are not ignored #22847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrgrain
changed the title
mrgrain
force-pushed
the
mrgrain/fix/integ-test-ignore-stack-assets
branch
2 times, most recently
from
41ee4c5
to
0f54a68
Compare
mrgrain
force-pushed
the
mrgrain/fix/integ-test-ignore-stack-assets
branch
from
0f54a68
to
8aa9630
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Closed in favor of #22881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested stack templates can contain assets and the hash is therefore going to change anytime an asset changes inside the nested stack. This defeats the purpose of
diffAsset: false.The actual nested stack template is still part of the snapshot, so any changes other than assets in the nested such l stack will require redeployment.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license