Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(eks): information on cluster versioning #22939

Closed
wants to merge 4 commits into from

Conversation

watany-dev
Copy link
Contributor

This is a simple fix around the documentation that I think is necessary, based on the issues regarding the v_1.22 and 1.23 updates. Of course, it remains to be seen if all of the changes will be applied, but I have added some descriptions that I hope users will find useful.

  1. update the version to be set in the cluster from 1.21 to 1.23 as an example in the readme
  2. addition of @deprecated. Supplement to non-compliant version
  3. Added "Set Cluster Version" usage. To avoid panic when there is an issue with updating to a new version. (I did not know that it can be specified as a public method.)

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 16, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 16, 2022 16:51
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2 labels Nov 16, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@watany-dev watany-dev marked this pull request as draft November 19, 2022 07:20
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9c93350
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@watany-dev watany-dev closed this Nov 24, 2022
@watany-dev watany-dev deleted the doc-eks-cluster-version-chore branch November 24, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants