Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix various typos #23020

Merged
merged 6 commits into from
Nov 24, 2022
Merged

docs: fix various typos #23020

merged 6 commits into from
Nov 24, 2022

Conversation

Naumel
Copy link
Contributor

@Naumel Naumel commented Nov 21, 2022 •
edited
Loading

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 21, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2022 18:19
@github-actions github-actions bot added the p2 label Nov 21, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 21, 2022
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@Naumel Naumel added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Nov 21, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2022 18:28

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@Naumel Naumel marked this pull request as ready for review November 22, 2022 08:46
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Nov 22, 2022
@Naumel Naumel changed the title fix: Typos galore docs: fix various typos Nov 22, 2022
@Naumel Naumel removed the pr/do-not-merge This PR should not be merged at this time. label Nov 22, 2022
@Naumel
Copy link
Contributor Author

Naumel commented Nov 22, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2022

update

✅ Branch has been successfully updated

@Naumel
Copy link
Contributor Author

Naumel commented Nov 23, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

update

✅ Branch has been successfully updated

@Naumel
Copy link
Contributor Author

Naumel commented Nov 24, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2022

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f043468
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 52edf29 into main Nov 24, 2022
@mergify mergify bot deleted the typos branch November 24, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naumel @aws-cdk-automation @mrgrain