fix(core): the string 'undefined' is recognized as a valid partition when looking up for fact values

[huyphan]

When the partition value is the literal string 'undefined' (because it was stringified from the context), it should be treated as if it is actually undefined. When looking up a fact value, the two values are already considered the same in one code path, but are then treated differently in the immediate logic. This is causing a new integration test to fail.

This commit makes the logic consistent.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[huyphan]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

I'm not adding extra integration tests because the existing tests are actually failing without this fix, we just don't see the failures because we are not running the tests with --force option. Here's a failure example when that flag is enabled:

# Run this in packages/@aws-cdk/aws-lambda 

❯ yarn integ integ.lambda-insights-mapping.js --update-on-failed --verbose --force
yarn run v1.22.4
$ integ-runner integ.lambda-insights-mapping.js --update-on-failed --verbose --force

Verifying integration test snapshots...

  UNCHANGED  integ.lambda-insights-mapping 3.566s

Snapshot Results:

Tests:    1 passed, 1 total

Running integration tests for failed tests...

Running in parallel across regions: us-east-1, us-east-2, us-west-2
Running test /Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/test/integ.lambda-insights-mapping.js in us-east-1

/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/core/lib/private/region-lookup.js:17
            throw new Error(`region-info: don't have any information for ${factName}. Use 'Fact.register' to provide values, or add partitions to the '${cxapi.TARGET_PARTITIONS}' context value.`);
            ^

Error: region-info: don't have any information for cloudwatch-lambda-insights-version:1_0_54_0_x86_64. Use 'Fact.register' to provide values, or add partitions to the '@aws-cdk/core:target-partitions' context value.
    at Object.deployTimeLookup (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/core/lib/private/region-lookup.js:17:19)
    at Stack.regionalFact (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/core/lib/stack.js:729:32)
    at getVersionArn (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/lib/lambda-insights.js:113:23)
    at InsightsVersion._bind (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/lib/lambda-insights.js:56:26)
    at Function.configureLambdaInsights (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/lib/function.js:662:121)
    at new Function (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/lib/function.js:277:14)
    at Object.<anonymous> (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/test/integ.lambda-insights-mapping.js:7:1)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)

Subprocess exited with error 1
  FAILED     integ.lambda-insights-mapping-integ.lambda-insights-mapping (undefined/us-east-1) 82.296s
      Integration test failed: Error: Command exited with status 1

Test Results:

Tests:    1 failed, 1 total
   --- Integration test metrics ---
Profile undefined + Region us-east-1 total time: 82.297
  /Users/hphan/workspace/aws-cdk/packages/@aws-cdk/aws-lambda/test/integ.lambda-insights-mapping.js: 82.297
Error: Some integration tests failed!
    at main (/Users/hphan/workspace/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:144:23)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[corymhall]

Weird one, thanks for the fix!

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: eff1f14
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).